Re: [Xen-devel] [PATCH] qemu-xen: free all the pirqs for msi/msix when driver unload

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 2 Jul 2013, DuanZhenzhong wrote:
> Stefano Stabellini wrote:
> > On Mon, 1 Jul 2013, Zhenzhong Duan wrote:
> >   
> > > Pirqs are not freed when driver unload, then new pirqs are allocated when
> > > driver reload. This could exhaust pirqs if do it in a loop.
> > > 
> > > This patch fixes the bug by freeing pirqs when ENABLE bit is cleared in
> > > msi/msix control reg.
> > > 
> > > There is also other way of fixing it such as reuse pirqs between driver
> > > reload,
> > > but this way is better.
> > > Xen-devel: http://marc.info/?l=xen-devel&m=136800120304275&w=2
> > > 
> > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>
> > >     
> > 
> > It looks OK to me, I'll have to trust you to have tested this patch
> > properly too.
> >   
> Not yet, it just passed build test.
> Pls hold off until I got permit to override the 4.1.30-OVM test env with
> upstream things and test.

OK, thanks for letting me know.


> Or is there some way of testing with 4.1.30-OVM + qemu-system-i386 ?

Uhm.. I guess not: you need QMP support in libxl and create VMs with xl
to be able to use qemu-xen.

Your best bet would be to update the hypervisor and tools to 4.2 or 4.3. 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel