Re: [Xen-devel] revert commit e4fd0475 ("hvmloader: always include HPET table")

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.13 at 13:45, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
> Il 03/07/2013 13:43, Jan Beulich ha scritto:
>> Windows SVVP tests requiring a HPET ACPI table is in my opinion
>> not a valid reason to always expose that table - respective tests
>> should be run with "hpet=1" in the guest config file.
>> 
>> The problem here is that at least with qemu-traditional, which
>> by default doesn't appear to emulate a HPET,
> 
> Isn't the HPET emulated in the hypervisor anyway?

No:

static int hpet_range(struct vcpu *v, unsigned long addr)
{
    return (v->domain->arch.hvm_domain.params[HVM_PARAM_HPET_ENABLED] &&
            (addr >= HPET_BASE_ADDRESS) &&
            (addr < (HPET_BASE_ADDRESS + HPET_MMAP_SIZE)));
}

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel