Re: [Xen-devel] [PATCH V2 1/2] xen: arm: introduce Cortex-A7 support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-07-03 at 06:43 -0600, Bamvor Jian Zhang wrote:

> > Since we already have physoffset in r10 would it be clearer to make use
> > of that?
> sorry if i am wrong. do u mean change "adr lr, 1f" to something like 
> "add lr, pc, r10"?

I think I was thinking
        add r1, r10, [r1, #PROCINFO_cpu_init]
        bl r1

(I'm sure I've got the operands to the add subtly wrong somehow, but
hopefully you get the gist of it).

> > 
> > [...]
> > > +#ifndef __ASM_ARM_ARM32_PROCINFO_H
> > > +#define __ASM_ARM_ARM32_PROCINFO_H
> > > +
> > > +struct proc_info_list {
> > > + unsigned int            cpu_val;
> > 
> > I think we should include "unsigned int cpu_mask" here too and remove
> > MIDR_MASK. Will need equivalent changes in head.S as well.
> yes, i need to do this for Aarch64 extesion in future.


Does MIDR differ between 32- and 64-bit? I must confess I've not checked
but assumed it was the same format.

> > 
> > > + unsigned long           cpu_init;        /* used by head.S */
> > > +};
> > > +
> > > +#endif
> > > diff --git a/xen/include/asm-arm/processor-ca15.h 
> > > b/xen/include/asm-arm/processor-ca15.h
> > > index 06cdbdd..96438f0 100644
> > > --- a/xen/include/asm-arm/processor-ca15.h
> > > +++ b/xen/include/asm-arm/processor-ca15.h
> > > @@ -1,9 +1,6 @@
> > >  #ifndef __ASM_ARM_PROCESSOR_CA15_H
> > >  #define __ASM_ARM_PROCESSOR_CA15_H
> > >  
> > > -
> > > -#define CORTEX_A15_ID     (0x410FC0F0)
> > > -
> > >  /* ACTLR Auxiliary Control Register, Cortex A15 */
> > >  #define ACTLR_CA15_SNOOP_DELAYED      (1<<31)
> > >  #define ACTLR_CA15_MAIN_CLOCK         (1<<30)
> > > @@ -26,7 +23,6 @@
> > >  #define ACTLR_CA15_OPT                (1<<9)
> > >  #define ACTLR_CA15_WFI                (1<<8)
> > >  #define ACTLR_CA15_WFE                (1<<7)
> > > -#define ACTLR_CA15_SMP                (1<<6)
> > 
> > Lets leave this for completeness even if we aren't using it.
> i was thinking about it. if i define the following
> #define ACTLR_CA15_SMP                ACTLR_V7_SMP

I meant just leave it as 1<<6.

> i need include asm/arm/processor.h which including CP micros.
> 
> Bamvor
> > 
> > >  #define ACTLR_CA15_PLD                (1<<5)
> > >  #define ACTLR_CA15_IP                 (1<<4)
> > >  #define ACTLR_CA15_MICRO_BTB          (1<<3)
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel