Re: [Xen-devel] [PATCH V2 2/2] xen: arm: implement early prink for 8250 uart

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-07-03 at 21:48 +0800, Chen Baozi wrote:
> On Jul 3, 2013, at 9:38 PM, "Bamvor Jian Zhang" <bjzhang@xxxxxxxx> wrote:
> 
> >>>> Wrote "Ian Campbell <Ian.Campbell@xxxxxxxxxx>"> On Tue
> >> On Tue, 2013-07-02 at 21:11 +0800, Bamvor Jian Zhang wrote:

> >>> +#define UART_TX           (0x00<<2)    /* Out: Transmit buffer */
> >>> +#define UART_LSR          (0x05<<2)    /* In:  Line Status Register */
> >> 
> >> Is the shift 2 on Baozi's platform too? Perhaps this could be a #define
> >> provided in the same style as EARLY_UART_BASE_ADDRESS or via some other
> >> means?
> >> 
> >> The definitions themselves duplicate those in
> >> xen/drivers/char/ns16550.c, perhaps we could refactor those into a
> >> suitable header?
> > yes. it should be. meanwhile considering the shift bit and other things. 
> > i am not sure how to merge the headers until i got the ns16550 actual used 
> > by
> > arm SOC. 
> Actually, I've already modified ns16550 driver to work on my platform. And it 
> also has the shift problem.
> 
> If you like, I could send a patch to refactor it, :-)

Yes please!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel