Re: [Xen-devel] [PATCH] libxl_json: Fix backport of JSON_BOOL to 4.2.2

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

Don Slutz <dslutz@xxxxxxxxxxx> wrote:

>On 07/05/13 16:29, Konrad Rzeszutek Wilk wrote:
>> Don Slutz <dslutz@xxxxxxxxxxx> wrote:
>>
>>> Looks like I had an issue with the mailer I used, and this did not
>get
>>> to anyone at citrix.com. Resending via a different SMTP server.
>>>     -Don Slutz
>>>
>>> On 07/05/13 11:11, Don Slutz wrote:
>>>> Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of
>>> obj->u.b
>>>> Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not.
>>>>
>>>> This shows up by vnc-port and vnc-listen are missing in xenstore
>when
>>> they should not be.
>>>> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
>>>> ---
>>>>    tools/libxl/libxl_json.c |    1 +
>>>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
>>>> index 72b52e8..0810630 100644
>>>> --- a/tools/libxl/libxl_json.c
>>>> +++ b/tools/libxl/libxl_json.c
>>>> @@ -474,6 +474,7 @@ static int json_callback_boolean(void *opaque,
>>> int boolean)
>>>>    
>>>>        if ((obj = libxl__json_object_alloc(ctx->gc, JSON_BOOL)) ==
>>> NULL)
>>>>            return 0;
>>>> +    obj->u.b = boolean;
>>>>    
>>>>        if (libxl__json_object_append_to(ctx->gc, obj, ctx->current)
>==
>>> -1) {
>>>>            libxl__json_object_free(ctx->gc, obj);
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@xxxxxxxxxxxxx
>>> http://lists.xen.org/xen-devel
>> Could you also include in the commit description not just the git
>commit id but also also the title of said patches? Thanks
>How does this look:
>
>    Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of 
>obj->u.b
>     libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL.
>
>     Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not.
>     libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL.
>
>     This shows up by vnc-port and vnc-listen are missing in xenstore 
>when they should not be.
>
>for the commit message?
>    -Don Slutz

I don't have my git tree in front of me but are you sure that both git commits 
have the same title.  That would be pretty odd. 

Anyhow I usually just include the title right after the commit as: git commit 
xyz ('title of said patch'). 
-- 
Sent from my Android phone. Please excuse my brevity.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel