Re: [Xen-devel] [PATCH v6 0/5] Xen/ACPI: support sleep state entering on hardware reduced systems

[Ben Guthro <Benjamin.Guthro@xxxxxxxxxx>]

On 07/08/2013 09:10 AM, Rafael J. Wysocki wrote:
> On Sunday, July 07, 2013 08:13:15 PM Ben Guthro wrote:
>> On Mon, Jul 1, 2013 at 7:48 AM, Ben Guthro <benjamin.guthro@xxxxxxxxxx> 
>> wrote:
>>> In version 3.4 acpi_os_prepare_sleep() got introduced in parallel with
>>> reduced hardware sleep support, and the two changes didn't get
>>> synchronized: The new code doesn't call the hook function (if so
>>> requested). Fix this, requiring a boolean parameter to be added to the
>>> hook function to distinguish "extended" from "legacy" sleep.
>>>
>>> This requires adjusting TXT, but the adjustments only go as far as
>>> failing the extended mode call (since, looking at the TXT interface,
>>> there doesn't even appear to be precautions to deal with that
>>> alternative interface).
>>>
>>> The hypervisor change underlying this is commit 62d1a69 ("ACPI: support
>>> v5 (reduced HW) sleep interface") on the master branch of
>>> git://xenbits.xen.org/xen.git.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> Signed-off-by: Ben Guthro <benjamin.guthro@xxxxxxxxxx>
>>> Cc: Richard L Maliszewski <richard.l.maliszewski@xxxxxxxxx>
>>> Cc: Gang Wei <gang.wei@xxxxxxxxx>
>>> Cc: Shane Wang <shane.wang@xxxxxxxxx>
>>> Cc: Bob Moore <robert.moore@xxxxxxxxx>
>>> Cc: Rafael J. Wysocki <rjw@xxxxxxx>
>>> Cc: linux-acpi@xxxxxxxxxxxxxxx
>>> Cc: tboot-devel@xxxxxxxxxxxxxxxxxxxxx
>>>
>>> v2: Extend description to include reference to hypervisor side change
>>> v3: Split into multiple patches, separating subsystems
>>>     Remove bool parameters, in favor of u8
>>> v4: Remove linux/acpi.h dependencies
>>>     Further patch split to break out acpica from OSL
>>>     More bool vs u8 fixes
>>> v5: Fix build of consumers of acpi_os_prepare_sleep() interface change,
>>>     so intermediate builds of partial patch series will not fail.
>>> v6: Rebased to linux-pm linux-next branch
>>>     Added warning in tboot early return code
>>>     Added Reviewed-by lines
>>>
>>> Ben Guthro (5):
>>>   acpi: Remove need to include linux/acpi.h in common acpica code
>>>   acpi: Call acpi_os_prepare_sleep hook in reduced hardware sleep path
>>>   acpi/xen/tboot: Adjust linux acpi OS functions to new extended
>>>     parameter
>>>   x86/tboot: Fail extended mode reduced hardware sleep
>>>   xen/acpi: notify xen when reduced hardware sleep is available
>>
>> Rafael, Bob -
>>
>> Is this version of the series something that you may consider taking?
>> If not - is there something specific you would like to see addressed?
> 
> Well, I'm afraid you need to give us some more time to process that,
> sorry.

My apologies - I know it is a busy time during the merge window. I did
not mean to seem impatient.

With the volume of things on the mailing list, I merely wanted to try to
avoid the series getting buried. If a week is too frequent to re-bump a
series, do you have a set of recommendations of how to best interact
with your workflow?

I'm just trying to balance people's time to review such things, with the
volume of the list.

Thanks for your time.

Ben

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel