Re: [Xen-devel] [PATCH 18/18] PVH xen: introduce vmx_pvh.c

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Mon, 08 Jul 2013 09:31:17 +0100
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 06.07.13 at 03:31, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> > Ok, lmk if you are ok with following:
> 
> Fundamentally yes. But ...
> 
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -41,6 +41,7 @@ obj-y += numa.o
> >  obj-y += pci.o
> >  obj-y += percpu.o
> >  obj-y += physdev.o
> > +obj-y += pvh.o
> 
> Does this indeed warrant a separate file?

yeah, i wasn't sure about that, but was not sure where to put it. I
think we could just have hvm_kernel_mode() next to
hvm_get_segment_register in hvm.h. It can then also be used in HVM code
in various places where it currently checks for dpl/cpl.


thanks
Mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel