Re: [Xen-devel] [PATCH v3 1/3][xen-netback] add a pseudo pps rate limit

[Sander Eikelenboom <linux@xxxxxxxxxxxxxx>]

Tuesday, July 9, 2013, 2:24:07 PM, you wrote:

> This patch provides a new option to limit VMs maximum packets per second
> emission rate.
> It follows the same credits logic used for throughput shaping. For the
> moment we have considered each "txreq" as a packet.
> PPS limits is passed to VIF at connection time via xenstore.
> PPS credit uses the same usecond period used by rate shaping check.

> known limitations:
> - by using the same usecond period, PPS shaping depends on throughput
>   shaping.
> - it is not always true that a "txreq" correspond to a packet
>   (fragmentation cases) but as this shaping is meant to avoid DDOS
>   (small paquets) such an approximation should not impact the results.
> - Some help on burst handling will be appreciated.

Just wondering, why should this be done in the drivers ?
Couldn't this also be achieved with netfilter and the recent/limit modules ?
The limit module can already handle bursts.

--
Sander


> Signed-off-by: Ahmed Amamou <ahmed@xxxxxxxxx>
> Signed-off-by: William Dauchy <william@xxxxxxxxx>
> Signed-off-by: Kamel Haddadou <kamel@xxxxxxxxx>
> ---


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel