[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: arm: correct vfp save/restore asm constraints.



>>> On 10.07.13 at 12:36, Ian Campbell <ijc@xxxxxxxxxxxxxx> wrote:
> On Wed, 2013-07-10 at 02:05 -0700, Julien Grall wrote:
>> On Mon, Jul 8, 2013 at 7:19 AM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
>> > Some versions of gcc complain:
>> >> vfp.c: In function 'vfp_restore_state':
>> >> vfp.c:45:27: error: memory input 0 is not directly addressable
>> >> vfp.c:51:31: error: memory input 0 is not directly addressable
>> >
>> > There is no way to express the constraint we want (which is the address of 
> the
>> > array, clobbering the whole array). Therefore we have to fake it up by 
> using
>> > two constraints.
>> >
>> > Signed-off-by: Ian Campbell <ijc@xxxxxxxxxxxxxx>
>> > Acked-by: Will.Deacon@xxxxxxx 
>> 
>> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Thanks, I'd commit this ASAP since it has broken the push tests but
> unfortunately I'm travelling and the ssh gateway I would need to use is
> down. (which is also why this comes from my personal email).
> 
> If one of the other committers wants to throw this in in the meantime
> then please do so.

Done.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.