Re: [Xen-devel] [RFC Patch v2 13/16] xc_domain_save: flush cache before calling callbacks->postcopy()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/07/13 09:35, Wen Congyang wrote:
> callbacks->postcopy() may use the fd to transfer something to the
> other end, so we should flush cache before calling callbacks->postcopy()
>
> Signed-off-by: Ye Wei <wei.ye1987@xxxxxxxxx>
> Signed-off-by: Jiang Yunhong <yunhong.jiang@xxxxxxxxx>
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> ---

This looks like it is a bugfix on its own, so perhaps might be better
submitted as individual fix, rather than being mixed in with a huge
series for new functionaltiy

~Andrew

>  tools/libxc/xc_domain_save.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c
> index fbc15e9..b477188 100644
> --- a/tools/libxc/xc_domain_save.c
> +++ b/tools/libxc/xc_domain_save.c
> @@ -2034,9 +2034,6 @@ int xc_domain_save(xc_interface *xch, int io_fd, 
> uint32_t dom, uint32_t max_iter
>   out:
>      completed = 1;
>  
> -    if ( !rc && callbacks->postcopy )
> -        callbacks->postcopy(callbacks->data);
> -
>      /* guest has been resumed. Now we can compress data
>       * at our own pace.
>       */
> @@ -2066,6 +2063,9 @@ int xc_domain_save(xc_interface *xch, int io_fd, 
> uint32_t dom, uint32_t max_iter
>  
>      discard_file_cache(xch, io_fd, 1 /* flush */);
>  
> +    if ( !rc && callbacks->postcopy )
> +        callbacks->postcopy(callbacks->data);
> +
>      /* Enable compression now, finally */
>      compressing = (flags & XCFLAGS_CHECKPOINT_COMPRESS);
>  


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel