Re: [Xen-devel] [PATCH 2/3] V4 qemu-xen-trad: Correctly expose PCH ISA bridge for IGD passthrough

[Pasi Kärkkäinen <pasik@xxxxxx>]

Hello,

IanJ: I think this patch should be able to go in now that Xen 4.3 is out of the 
way? 


On Thu, Jun 20, 2013 at 02:31:44PM +0100, Stefano Stabellini wrote:
> On Mon, 17 Jun 2013, G.R. wrote:
> > On Mon, Jun 17, 2013 at 8:54 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> > >>>> On 17.06.13 at 14:42, "G.R." <firemeteor@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > >> The i915 driver probes chip version through PCH ISA bridge device / 
> > >> vendor
> > >> ID.
> > >> Previously, the PCH ISA bridge is exposed as PCI-PCI bridge in 
> > >> qemu-xen-trad,
> > >> which breaks the assumption of the driver. This change fixes the issue by
> > >> correctly exposing the ISA bridge to domU.
> > >>
> > >> Note the PIIX3 ISA bridge is still present on the bus (dropping it seems
> > >> break qemu all-together), i915 driver still need to be updated to handle
> > >> this.
> > >>
> > >> Change since last version:
> > >>   1. Introduce helper function to avoid exposing PCI_Bus / PCI_Bridge
> > >> definition to public.
> > >>
> > >> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>,
> > >>                Rui Guo <firemeteor@xxxxxxxxxxxxxxxxxxxxx>
> > >> Tested-by: Rui Guo <firemeteor@xxxxxxxxxxxxxxxxxxxxx>
> > >
> > > I'm fine with this version, but does the above indeed reflect
> > > reality? I.e. wasn't it you who wrote the patch in its current
> > > form?
> > >
> > 
> > Ah! Thanks for pointing this out...
> > I just keep carrying this sign-off lines from the original version.
> > So I think I should use these lines for signing-off:
> >  Signed-off-by: Rui Guo <firemeteor@xxxxxxxxxxxxxxxxxxxxx>
> >  Tested-by: Rui Guo <firemeteor@xxxxxxxxxxxxxxxxxxxxx>
> > 
> > Do I need to resend the whole thing out?
> 
> I think it's OK and Ian should be able to change those lines for you
>


-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel