Re: [Xen-devel] [PATCH resend 3/3] pciif: add multi-vector-MSI command

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.07.13 at 13:19, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 16/07/13 11:15, Jan Beulich wrote:
>> The requested vector count is to be passed in struct xen_pci_op's info
>> field. Upon failure, if a smaller vector count might work, the backend
>> will pass that smaller count in the value field (which so far is always
>> being set to zero in the error path).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/include/public/io/pciif.h
>> +++ b/xen/include/public/io/pciif.h
>> @@ -46,6 +46,7 @@
>>  #define XEN_PCI_OP_aer_resume               (7)
>>  #define XEN_PCI_OP_aer_mmio         (8)
>>  #define XEN_PCI_OP_aer_slotreset    (9)
>> +#define XEN_PCI_OP_enable_multi_msi (10)
> 
> /* Be sure to bump this number if you change this file */
> #define XEN_PCI_MAGIC "7"
> 
> Should you bump this version, or is the comment stale?  The only in-tree
> consumer I can find is MiniOS's pcifront, which writes it into xenstore.

Whether it's stale I don't know (likely it is considering that you
found just a single consumer), but bumping a revision just
because of the (backwards compatible) addition seems
superfluous to me. This would be different if I changed the
existing enable_msi...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel