[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] xen: allow architecture to choose how/whether to compress installed xen binary



>>> On 17.07.13 at 17:37, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> @@ -53,13 +55,14 @@ _install: $(TARGET).gz
>       fi
>  
>  .PHONY: _uninstall
> +_uninstall: Z=$(CONFIG_XEN_INSTALL_SUFFIX)
>  _uninstall: D=$(DESTDIR)
>  _uninstall: T=$(notdir $(TARGET))

As you will likely want to rev this series once more anyway after my
comment on patch 3, would you mind doing the above in (at the
same time, as it turns out) logical (path, name, extension) and
alphabetical order?

Jan

>  _uninstall:
> -     rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION).gz
> -     rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).gz
> -     rm -f $(D)/boot/$(T)-$(XEN_VERSION).gz
> -     rm -f $(D)/boot/$(T).gz
> +     rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION)$(Z)
> +     rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
> +     rm -f $(D)/boot/$(T)-$(XEN_VERSION)$(Z)
> +     rm -f $(D)/boot/$(T)$(Z)
>       rm -f $(D)/boot/$(T)-syms-$(XEN_FULLVERSION)
>       rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi
>       rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).efi
> -- 
> 1.7.2.5




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.