Re: [Xen-devel] [Patch v3] tools/migrate: Fix regression when migrating from older version of Xen

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2013-07-22 at 19:48 +0100, Andrew Cooper wrote:
> diff --git a/tools/libxl/libxl_save_helper.c b/tools/libxl/libxl_save_helper.c
> index 772251a..8f14b8b 100644
> --- a/tools/libxl/libxl_save_helper.c
> +++ b/tools/libxl/libxl_save_helper.c
> @@ -264,7 +264,7 @@ int main(int argc, char **argv)
>          r = xc_domain_restore(xch, io_fd, dom, store_evtchn, &store_mfn,
>                                store_domid, console_evtchn, &console_mfn,
>                                console_domid, hvm, pae, superpages,
> -                              no_incr_genidad, &genidad,
> +                              no_incr_genidad, 0, &genidad,
>                                &helper_restore_callbacks);
>          helper_stub_restore_results(store_mfn,console_mfn,genidad,0);
>          complete(r); 

Unfortunately I think you may need to plumb this one through as well, to
handle xl_cmdimpl.c:migrate_receive called with remus = 1.

This probably means adding a flags argument to
libxl_domain_create_restore. Bit tricky from a libxl API stability PoV,
we'll probably need to take advantage of the LIBXL_API_VERSION thing.
Bit of a faff but doable, Olaf had a reasonable looking scheme for
something in <f6fedb087442fb54e31d.1364481811@xxxxxxxxxxxx>.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel