Re: [Xen-devel] [PATCH 2/4] xen: switch to use hypervisor_cpuid_base()

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

Il 23/07/2013 11:41, Jason Wang ha scritto:
> Switch to use hypervisor_cpuid_base() to detect Xen.
> 
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/xen/hypervisor.h |   16 +---------------
>  1 files changed, 1 insertions(+), 15 deletions(-)
> 
> diff --git a/arch/x86/include/asm/xen/hypervisor.h 
> b/arch/x86/include/asm/xen/hypervisor.h
> index 125f344..d866959 100644
> --- a/arch/x86/include/asm/xen/hypervisor.h
> +++ b/arch/x86/include/asm/xen/hypervisor.h
> @@ -40,21 +40,7 @@ extern struct start_info *xen_start_info;
>  
>  static inline uint32_t xen_cpuid_base(void)
>  {
> -     uint32_t base, eax, ebx, ecx, edx;
> -     char signature[13];
> -
> -     for (base = 0x40000000; base < 0x40010000; base += 0x100) {
> -             cpuid(base, &eax, &ebx, &ecx, &edx);
> -             *(uint32_t *)(signature + 0) = ebx;
> -             *(uint32_t *)(signature + 4) = ecx;
> -             *(uint32_t *)(signature + 8) = edx;
> -             signature[12] = 0;
> -
> -             if (!strcmp("XenVMMXenVMM", signature) && ((eax - base) >= 2))
> -                     return base;
> -     }
> -
> -     return 0;
> +     return hypervisor_cpuid_base("XenVMMXenVMM", 2);
>  }
>  
>  #ifdef CONFIG_XEN
> 

Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel