Re: [Xen-devel] [PATCH 4 of 4 RFC] xl/remus: Add libnl3 dependency to autoconf scripts and libxl/Makefile

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Fri, Jul 26, 2013 at 5:44 AM, Wen Congyang <wency@xxxxxxxxxxxxxx> wrote:
> At 07/25/2013 03:09 PM, Shriram Rajagopalan Wrote:
>> Add dependency on libnl3 version 3.2.17 or higher to autoconf.
>> Add include flags and link to relevant libraries in tools/libxl/Makefile.
>
> Is it OK to use libnl, not libnl3?
> Some systems(For example: RHEL6) don't have libnl3.
>

Unfortunately no. libnl3 is where the network buffering support
exists. And most of the API
used to setup network buffering were introduced in libnl3.

>>
>> Signed-off-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>
>>
>> diff -r bef729fc4336 -r c4c05e4e4e02 tools/configure.ac
>> --- a/tools/configure.ac      Thu Jul 25 00:02:22 2013 -0700
>> +++ b/tools/configure.ac      Thu Jul 25 00:02:33 2013 -0700
>> @@ -171,4 +171,12 @@ AC_SUBST(libiconv)
>>  # Checks for header files.
>>  AC_CHECK_HEADERS([yajl/yajl_version.h sys/eventfd.h])
>>
>> +# Checks for libnl3 libraries and headers.
>> +PKG_CHECK_MODULES(LIBNL3, libnl-3.0 >= 3.2.17 libnl-route-3.0 >= 3.2.17, 
>> [have_libnl3=yes], [have_libnl3=no])
>> +if (test "${have_libnl3}" = "yes"); then
>> +        CFLAGS+="-I$LIBNL3_CFLAGS"
>> +else
>> +     AC_MSG_ERROR([Need libnl version 3.2.17 or higher])
>> +fi
>> +
>>  AC_OUTPUT()
>> diff -r bef729fc4336 -r c4c05e4e4e02 tools/libxl/Makefile
>> --- a/tools/libxl/Makefile    Thu Jul 25 00:02:22 2013 -0700
>> +++ b/tools/libxl/Makefile    Thu Jul 25 00:02:33 2013 -0700
>> @@ -13,7 +13,7 @@ XLUMINOR = 0
>>
>>  CFLAGS += -Werror -Wno-format-zero-length -Wmissing-declarations \
>>       -Wno-declaration-after-statement -Wformat-nonliteral
>> -CFLAGS += -I. -fPIC
>> +CFLAGS += -I. -fPIC -I /usr/local/include/libnl3/
>
> Hmm, why use /usr/local?
>

That was a hack, as stated in the introductory email. I am not well versed with
autoconf. Using pkg-config and adding the libraries to APPEND_INCLUDES
didnt do the job.

shriram

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel