Re: [Xen-devel] [PATCH] Don't take the domain lock for p2m operations.

[Tim Deegan <tim@xxxxxxx>]

At 09:31 -0400 on 29 Jul (1375090283), Andres Lagar-Cavilla wrote:
> > P2M ops are covered by their own locks, and these uses of the domain
> > lock are relics of shadow-v1 code.
> > 
> > Signed-off-by: Tim Deegan <tim@xxxxxxx>
> Reviewed-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> 
> What about other uses of the domain lock? Should a subsequent patch be cut, 
> or this one expanded?
> 
> By my count, the following uses of the domain lock in mm code could be 
> abolished or replaced by the p2m lock:
> * ARM's xenmem_add_to_physmap_once

Oops, good point.  v2 coming, with that one removed too.

> * emulation of cr3 write (traps.c)

That one's already gone in the staging tree.

> * And possibly x86's do_set_gdt, although I'm unclear about it

I'd rather now, at least not in this patch.  That's part of the PV
interface, and nothing to to with x86/mm/p2m.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel