Re: [Xen-devel] [PATCH 1/1 V4] x86/AMD: Fix nested svm crash due to assertion in __virt_to_maddr

["Egger, Christoph" <chegger@xxxxxxxxx>]

On 29.07.13 18:27, Suravee Suthikulanit wrote:
> On 7/29/2013 5:43 AM, Tim Deegan wrote:
>> Hi,
>>
>> At 16:46 -0500 on 26 Jul (1374857167), suravee.suthikulpanit@xxxxxxx
>> wrote:
>>> From: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
>>>
>>> Fix assertion in __virt_to_maddr when starting nested SVM guest
>>> in debug mode. Investigation has shown that svm_vmsave/svm_vmload
>>> make use of __pa() with invalid address.
>>>
>>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
>> This looks much better, but I have a few comments still:

Indeed.

>>
>>> +static struct page_info *
>>> +_get_vmcb_page(struct domain *d, uint64_t vmcbaddr)
>> Can you give this a name that makes it clearer that it's for nested
>> VMCBs and not part of the handling of 'real' VMCBs?  Also, please drop
>> the leading underscore.
> What about "get_nvmcb_page"?
> 

That's good. If you want to follow the naming scheme I suggest
nsvm_get_nvmcb_page().

Christoph


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel