Re: [Xen-devel] [PATCH 2/8] pl011: Move registers' definition in a separate file

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-07-29 at 17:35 +0100, Julien Grall wrote:
> On 07/29/2013 05:24 PM, Ian Campbell wrote:
> > Should we prefix them with PL011 or something?
> 
> This header is intended to be used only in the C drivers and early printk.
> 
> But I can prefix by UART... which is the real name for the registers.

"real name" in what sense? The offsets are specific to the PL011, aren't
they? Or are you saying they are common with the 16550 offsets?

It's bad enough that the 16550 header uses UART prefix without adding a
second potentially conflicting user of that namespace

> I didn't choose this solution to avoid lots of changes in the PL011 driver.

That's a reasonable point. Lets leave them alone until it becomes a real
problem.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel