Re: [Xen-devel] [PATCH v2] xen: arm: handle traps of conditional instructions.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-07-30 at 11:37 +0100, Julien Grall wrote:
> On 29 July 2013 17:31, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Mon, 2013-07-29 at 17:08 +0100, Ian Campbell wrote:
> >> This means handling the HSR.ccvalid field as well as correctly processing 
> >> the
> >> Thumb If-Then state block in the CPSR correctly which is rather tricky. KVM
> >> provided a useful reference for all this.-
> >>
> >> I suspect we aren't actually hitting these paths very often since the 
> >> sorts of
> >> traps we take will not often be conditional so my limited testing may not
> >> actually be exercising these paths very much.
> >>
> >> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >> ---
> >> v2: Fixup typos and coding style violations spotted by Julien.
> >
> > Julien, you said "I'm able to hit this path only once on the Arndale".
> > Does that mean you can't easily reproduce at will? Wuld be nice to give
> > it a workout but in the absence of that I think this is better than
> > nothing? The clever bits come mostly as is from Linux so it's probably
> > OK. (famous last words...)
> 
> As you said, it's hard to reproduce it on both Versatile Express and
> the Arndale. When I tried the logic by hand I didn't see any specific issue.
> 
> Acked-by: Julien Grall <julien.linaro.org>

Thanks, applied.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel