Re: [Xen-devel] [PATCH] Fix stubdom undeclared function build warnings

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-07-29 at 11:18 +0200, Samuel Thibault wrote:
> This includes a few headers to fix some missing function declarations.

I inserted: 

../grub-upstream/stage2/builtins.c:1728:3: warning: implicit declaration of 
function âdo_exitâ [-Wimplicit-function-declaration]
stubdom/include/xen/libelf/libelf.h:453:5: warning: implicit declaration of 
function âmemcpyâ [-Wimplicit-function-declaration]

> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Acked + added a Reported-by for IAN + applied. 

> 
> diff --git a/stubdom/grub/config.h b/stubdom/grub/config.h
> index 1649d51..15a6583 100644
> --- a/stubdom/grub/config.h
> +++ b/stubdom/grub/config.h
> @@ -2,6 +2,7 @@
>  #undef putchar
>  #include <ctype.h>
>  #include <string.h>
> +#include <kernel.h>
>  #define debug _debug
>  #define grub_halt(a) do_exit()
>  #define printf grub_printf
> diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h
> index 2a6fa54..e65db6d 100644
> --- a/xen/include/xen/libelf.h
> +++ b/xen/include/xen/libelf.h
> @@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
>  #ifdef __XEN__
>  #include <public/elfnote.h>
>  #include <public/features.h>
> +#include <xen/string.h>
>  #else
>  #include <xen/elfnote.h>
>  #include <xen/features.h>
>  
>  #include <stdarg.h>
> +#include <string.h>
>  
>  struct elf_binary;
>  typedef void elf_log_callback(struct elf_binary*, void *caller_data,
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel