Re: [Xen-devel] [V10 PATCH 14/23] PVH xen: additional changes to support PVH guest creation and execution.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-08-07 at 16:50 +0100, George Dunlap wrote:
> On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> 
> wrote:
> >
> > @@ -443,6 +445,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
> > u_domctl)
> >          domcr_flags = 0;
> >          if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_hvm_guest )
> >              domcr_flags |= DOMCRF_hvm;
> > +        else if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_hap )
> > +            domcr_flags |= DOMCRF_pvh;     /* PV with HAP is a PVH guest */
> 
> Um, wait a minute -- I don't think we want to exclude the possibility
> of *ever* having PVH with shadow pagetables, do we?  Wouldn't it make
> more sense to just add XEN_DOMCTL_CDF_pvh_guest?

This is a domctl so we can always change the interface if it comes to
it.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel