Re: [Xen-devel] [V10 PATCH 10/23] PVH xen: domain create, context switch related code changes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.08.13 at 11:02, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> Overall I think checking before calling would make the code easier to 
> understand.  All the functions which call this have is_foo_domain() 
> sprinkled all over anyway, and so it's easier for someone reading the 
> code to understand immediately that HVM and PVH guests don't need their 
> gdt destroyed.  But my main point was that if we check inside the 
> function, we should avoid checking outside the function for consistency.

And I fully agree with that (here as well as in the various cases
where such redundancy already exists in the code).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel