Re: [Xen-devel] [PATCH v5 2/5] xen/arm: add 8250 compatible UART support for early_printk

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-08-08 at 18:52 +0800, Chen Baozi wrote:
> Both OMAP5 and sun6i SoCs share this UART driver for early_printk.
> 
> Signed-off-by: Chen Baozi <baozich@xxxxxxxxx>
> ---
>  docs/misc/arm/early-printk.txt    |  2 ++
>  xen/arch/arm/Rules.mk             |  8 ++++++++
>  xen/arch/arm/arm32/debug-8250.inc | 41 
> +++++++++++++++++++++++++++++++++++++++
>  xen/include/xen/8250-uart.h       |  4 ++++
>  4 files changed, 55 insertions(+)
>  create mode 100644 xen/arch/arm/arm32/debug-8250.inc
> 
> diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt
> index fbc3208..f24c6c0 100644
> --- a/docs/misc/arm/early-printk.txt
> +++ b/docs/misc/arm/early-printk.txt
> @@ -13,6 +13,8 @@ where mach is the name of the machine:
>    - exynos5250: printk with the second UART
>    - midway: printk with the pl011 on Calxeda Midway processors
>    - fastmodel: printk on ARM Fastmodel software emulators
> +  - omap5432: printk with UART3 on TI OMAP5432 processors
> +  - sun6i: printk with 8250 on Allwinner A31 processors

We've not been terribly consistent about SoC vs board naming here. I
think this is fine, we can always tweak in the future.

I had a comment below so when you respin and can be bothered please can
you also add
 sun7i: printk with 8250 on Allwinner A20 processors

and the appropriate block (identical to sun6i block).
> diff --git a/xen/include/xen/8250-uart.h b/xen/include/xen/8250-uart.h
> index 7287364..33daa6d 100644
> --- a/xen/include/xen/8250-uart.h
> +++ b/xen/include/xen/8250-uart.h
> @@ -22,6 +22,10 @@
>  #ifndef __XEN_8250_UART_H__
>  #define __XEN_8250_UART_H__
>  
> +#ifdef CONFIG_ARM
> +#define REG_SHIFT         2
> +#endif

I think this should actually be part of the per-platform early-printk
block, e.g. EARLY_UART_REG_SHIFT

> +
>  /* Register offsets */
>  #define UART_RBR          0x00    /* receive buffer       */
>  #define UART_THR          0x00    /* transmit holding     */



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel