Re: [Xen-devel] [PATCH V12 0/14] Paravirtualized ticket spinlocks

[Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>]

On 08/09/2013 06:34 AM, H. Peter Anvin wrote:
> The kbuild test bot is reporting some pretty serious errors for this
> patchset.  I think these are serious enough that the patchset will need
> to be respun.
There were two problems:
(1) we were including spinlock_types.h in 
arch/x86/include/asm/paravirt_types.h.
This was resulting in redefinition of arch_spinlock_t for non SMP kernel

solution was :
conditional inclusion of spinlock_types.h like below

#ifdef CONFIG_SMP
#include <asm/spinlock_types.h>
#else
typedef u16 __ticket_t;
#endif

(we needed __ticket_t declaration for UP)

(2) we had forward declaration of atomic_read in jumpl_label.
It was causing problem for alpha, which has macro for atomic_read
instead of static inline.

Solution was to remove forward declaration and have atomic.h included.

Peter,
 the above two changes needs small changes in patch 1 and patch 9.
I 'll be resending only those two patches.

I am happy to resend the whole series if it is better and easier for
you.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel