Re: [Xen-devel] [PATCH] xentrace: add a tool to break down the result of vmexit

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Fri, Aug 9, 2013 at 2:28 PM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Fri, Aug 09, 2013 at 10:10:19AM +0100, George Dunlap wrote:
>> On 09/08/13 09:54, Zhang, Yang Z wrote:
>> >Zhang, Yang Z wrote on 2013-08-09:
>> >>George Dunlap wrote on 2013-08-09:
>> >>>On Fri, Aug 9, 2013 at 7:34 AM, Yang Zhang <yang.z.zhang@xxxxxxxxx>
>> >>wrote:
>> >>>>From: Yang Zhang <yang.z.zhang@xxxxxxxxx>
>> >>>>
>> >>>>The tool is able to provide a summary of vmexit. Currently, it only
>> >>>>supports to summay one VCPU result at a time.
>> >>>Have you seen xenalyze?
>> >>>
>> >>>hg clone http://xenbits.xen.org/ext/xenalyze
>> >>Thanks. Now I see it. It's a great tool.
>> >Does it integrate to Xen source? If no, it's better to add it to 
>> >tool/xentrace/ instead use a separate repo to let more people know it. :)
>>
>> Yes, this has been suggested before.  The original reason for having
>> it be a separate repo is that most of the xenalyze development
>> happened after a Xen release.  But I think it has more or less
>> reached a 1.0 level some time ago, and isn't seeing as many changes.
>>
>> I'm not sure what it would take to get it checked into the main
>> repo.  At the moment the code is just one massive file (with a
>> couple of helper files), and no doubt has a number of coding style
>> inconsistencies - though I there is certainly worse code in the
>> tree. :-)
>>
>> Ian / Ian, any thoughts?
>
> My opinion is that it should have the same treatment as any new
> code added - adhere to the StyleGuide.

I was mostly asking about having one monolithic file vs. being broken
down further.

If it requires many changes, I won't personally have time to get to it
this release cycle.  If anyone else wanted to clean it up and submit
on the other hand... :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel