Re: [Xen-devel] [PATCH 1/8] debug: remove some event channel info from the 'i' and 'q' debug keys

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.08.13 at 20:08, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> With different event channel ABIs, showing the 2-level selector word
> may be misleading (if a different ABI is in use).

I'm not sure removing potentially useful information is good
practice. How about you instead add an ABI specific dump
handler? Might be useful to also dump non-generic state
for your new implementation.

> When dumping domain information, printing the state of the VIRQ_DEBUG
> port is redundant -- this information is available via the 'e' key.

This part is clearly fine.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel