Re: [Xen-devel] [PATCH 07/12] xen/events: add struct evtchn_ops for the low-level port operations

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 16/08/13 18:47, Wei Liu wrote:
> On Fri, Aug 09, 2013 at 07:15:16PM +0100, David Vrabel wrote:
>> 
>> +    xen_evtchn_init_nlevel();
>> +
> 
> There is only 2-level ABI, more importantly, it is the default ABI, so
> use xen_evtchn_init_default instead?

It's not the default, FIFO is the default.  N-level is the fallback for
when the hypervisor doesn't support FIFO.

>> +
>> +static const struct evtchn_ops evtchn_ops_nlevel = {
>> +    .bind_to_cpu       = nlevel_bind_to_cpu,
>> +    .clear_pending     = nlevel_clear_pending,
>> +    .set_pending       = nlevel_set_pending,
>> +    .is_pending        = nlevel_is_pending,
>> +    .test_and_set_mask = nlevel_test_and_set_mask,
>> +    .mask              = nlevel_mask,
>> +    .unmask            = nlevel_unmask,
>> +    .handle_events     = nlevel_handle_events,
>> +};
>> +
> 
> How about use 2level_* or default_*?

Identifiers can't start with numbers.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel