Re: [Xen-devel] [PATCH v4 2/3] handle pps limit parameter

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH v4 2/3] handle pps limit parameter"):
> Suggest adding "libxl: " prefix in subject line.

Yes.

> Plus, you should CC Ian Jackson for toolstack patches (which I've
> already done for this mail).

Thanks.


Did this patch include a change to the documentation ?
(I don't know if Wei trimmed the patch.)

It introduces a new syntax.  The new syntax is rather exciting.  Is it
used anywhere else ?  What do other tools do ?

> One question I need to ask is that is it possible for user to only
> specify PPS? From previous email and the code below it doesn't seem to
> allow users to do so. I know rate and PPS use the same interval but that
> doesn't mean that the later depend on the former, right?

Good question.

Also, I have some comments about the implementation:

This patch seems to involve a lot of duplication of existing code.
I'm afraid I'll have to ask you to integrate it into the existing
code, factoring out common functionality as necessary.

The mixture of parsing with regexps and strtok was less than ideal to
start with, but it becomes worse with the new syntax complexity.  If
this syntax is really the one we want, I'd suggest looking again at
the possibility of using flex for part of it.  flex allows the syntax
to be described using an interleaved mixture of regexps and C code.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel