Re: [Xen-devel] [PATCH v4 1/4] xen/arm: implement steal_page

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-08-15 at 12:18 +0100, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

You needed to include the x86 folks here. Adding Keir and Jan.

Subject needs to change, you are no longer implementing steal_page but
moving it. I assume it is unchanged but please say so in the commit
message.

> +    /* Unlink from original owner. */
> +    if ( !(memflags & MEMF_no_refcount) && !domain_adjust_tot_pages(d, -1) )

We never call domain_adjust_tot_pages from anywhere on ARM -- I wonder
if we should be ;-)

Ah, the counter to this drop is in donate_page() -- which is define
right above steal_page on x86 and is an ASSERT(0) on x86. I don't think
it makes sense to move one without the other.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel