[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Correct X2-APIC HVM emulation


  • To: xen-devel@xxxxxxxxxxxxx, keir@xxxxxxx, jbeulich@xxxxxxxx
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Thu, 22 Aug 2013 11:15:19 +0200
  • Cc: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Delivery-date: Thu, 22 Aug 2013 09:15:47 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer; b=fvYt6qNYeLLGglnvXqZrfjeYzIr/dqVl3t2/PbIMXLq5obWL6sD4hHwZ xWLh3PpXLynDKpmAu4RhLXTix4WFZ4osrw8NCQzQnh7CsUel0e7uDMauR klCXesYqPLarfRWKTvNucsO1UySCF0pvedSI+AeL58LPy09dqysZAA/WE b5HKn13Ogm8k0RMTDSHLfusA78SJ+JM233gqpcMje524YS405fXpqw5vH yRwbUrhIY8dWuOppNr7easSI28//A;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

commit 6859874b61d5ddaf5289e72ed2b2157739b72ca5 introduced an error for the
hvm emulation of x2apic. Any try to write to APIC_ICR MSR will result in
a gp fault.

Signed-off-by: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
---
 xen/arch/x86/hvm/vlapic.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index 7a154f9..366dfc9 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -859,6 +859,7 @@ int hvm_x2apic_msr_write(struct vcpu *v, unsigned int msr, 
uint64_t msr_content)
         rc = vlapic_reg_write(v, APIC_ICR2, (uint32_t)(msr_content >> 32));
         if ( rc )
             return rc;
+        break;
 
     case APIC_ICR2:
         return X86EMUL_UNHANDLEABLE;
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.