Re: [Xen-devel] [PATCH 1 of 5] remus: add libnl3 dependency to autoconf scripts

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-08-26 at 10:06 +0100, Andrew Cooper wrote:
> On 26/08/2013 00:45, rshriram@xxxxxxxxx wrote:
> > # HG changeset patch
> > # User Shriram Rajagopalan <rshriram@xxxxxxxxx>
> > # Date 1377473602 25200
> > # Node ID 0ae8b121b67b3cb3a6b00f2cc97e98fec5758e20
> > # Parent  40b079bd57dea24c3b000f233ed123763483a4d5
> > remus: add libnl3 dependency to autoconf scripts
> >
> > Libnl3 is required for controlling Remus network buffering.
> > This patch adds dependency on libnl3 (>= 3.2.8) to autoconf scripts.
> > Also provide ability to configure tools without libnl3 support, that
> > is without network buffering support.
> >
> > Signed-off-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>
> 
> As identified in the patch 0, libnl3 is not present for CentOS (so by
> implication RHEL and derivatives) and various BSDs, so enabling it by
> default and erroring out of autoconf if it cant be found is not really
> acceptable imo.
> 
> It would be better to detect the presence/absence of an appropriate
> libnl3, and use that as the default.  Then, the logic would be: "By
> default build in libnl3 support if it is available, but don't if it is
> not.

This is the minimum we should require IMHO

>   If the user explicitlicy configures --with-remusnetbuf and libnl3
> is not present, present an error"

The presence of an option to force enable it is a stretch goal as far as
I'm concerned.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel