Re: [Xen-devel] [PATCH RFC 2/2] linux/vnuma: Enables NUMA support for PV guest

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 27/08/13 09:53, Elena Ufimtseva wrote:
> Enables NUMA support for PV guest and uses vNUMA
> interface to discover topology provided by XEN.
> 
> Signed-off-by: Elena Ufimtseva <ufimtseva@xxxxxxxxx>
> ---
>  arch/x86/xen/setup.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index 056d11f..7e0c93b 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -561,6 +561,6 @@ void __init xen_arch_setup(void)
>       WARN_ON(xen_set_default_idle());
>       fiddle_vdso();
>  #ifdef CONFIG_NUMA
> -     numa_off = 1;
> +     numa_off = 0;
>  #endif
>  }

Hmm. This is either safe to turn on now or it will break on hosts
without vNUMA support as it will cause a fallback to try all the
hardware specific NUMA initialization.

Which is it?

David


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel