Re: [Xen-devel] [PATCH v2-resend 02/30] libxl: idl: allow KeyedUnion members to be empty

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH v2-resend 02/30] libxl: idl: allow 
KeyedUnion members to be empty"):
> On Tue, 2013-08-27 at 15:59 +0100, Ian Jackson wrote:
> > You are introducing skankiness not in the IDL compiler, but in the IDL
> > itself.  I think it is better to have skankiness in some particular
> > language's output than in the IDL input.
> 
> I think:
> -                 ("invalid", Struct(None, [])),
> +                 ("invalid", None),
> 
> is reducing the amount of skank in the IDL, None has a good match with
> "nothing here", while "Strict(None, [])" is just random placeholder goo,
> which would be even worse if we were to artificially add a member

Well, I think we should keep the number of primitive types down to the
minimum possible.  But I think this discussion has gone on long
enough and it's not that important:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel