Re: [Xen-devel] [PATCH] x86/apic: remove DMI checks in bigsmp driver for obsolete systems

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/08/13 19:59, Matt Wilson wrote:
> The DMI checks that force the use of the bigsmp APIC driver are for
> systems that are no longer supported by Xen (32-bit x86).
>
> Signed-off-by: Matt Wilson <msw@xxxxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I did some googling.

While the two HP machines do indeed only support 32bit cpus (Intel
'Gallatin' series),

http://www.serverwatch.com/hreviews/article.php/3655386

indicates that the ES7000/ONE can be configured with 64bit Xeon CPUs,
and is therefore still supported by Xen.

~Andrew

> ---
>  xen/arch/x86/genapic/bigsmp.c |   30 +-----------------------------
>  1 files changed, 1 insertions(+), 29 deletions(-)
>
> diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c
> index 96b23d6..491a916 100644
> --- a/xen/arch/x86/genapic/bigsmp.c
> +++ b/xen/arch/x86/genapic/bigsmp.c
> @@ -8,36 +8,9 @@
>  #include <xen/kernel.h>
>  #include <xen/smp.h>
>  #include <xen/init.h>
> -#include <xen/dmi.h>
>  #include <asm/mach-default/mach_mpparse.h>
>  #include <asm/io_apic.h>
>  
> -static __init int force_bigsmp(struct dmi_system_id *d)
> -{
> -     printk(KERN_NOTICE "%s detected: force use of apic=bigsmp\n", d->ident);
> -     def_to_bigsmp = 1;
> -     return 0;
> -}
> -
> -
> -static struct dmi_system_id __initdata bigsmp_dmi_table[] = {
> -     { force_bigsmp, "HP ProLiant DL760 G2", {
> -             DMI_MATCH(DMI_BIOS_VENDOR, "HP"),
> -             DMI_MATCH(DMI_BIOS_VERSION, "P44-"),
> -     }},
> -
> -     { force_bigsmp, "HP ProLiant DL740", {
> -             DMI_MATCH(DMI_BIOS_VENDOR, "HP"),
> -             DMI_MATCH(DMI_BIOS_VERSION, "P47-"),
> -      }},
> -     { force_bigsmp, "UNISYS ES7000-ONE", {
> -             DMI_MATCH(DMI_PRODUCT_NAME, "ES7000-ONE")
> -      }},
> -     
> -      { }
> -};
> -
> -
>  static __init int probe_bigsmp(void)
>  { 
>       /*
> @@ -47,8 +20,7 @@ static __init int probe_bigsmp(void)
>       if (acpi_gbl_FADT.flags &
>           (ACPI_FADT_APIC_CLUSTER | ACPI_FADT_APIC_PHYSICAL))
>               def_to_bigsmp = 1;
> -     else if (!def_to_bigsmp)
> -             dmi_check_system(bigsmp_dmi_table);
> +
>       return def_to_bigsmp;
>  } 
>  


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel