Re: [Xen-devel] [PATCH] libvhd: use UTC for VHD timestamp

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-08-30 at 16:52 +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] libvhd: use UTC for VHD timestamp"):
> > Update commit message.
> 
> Thanks.
> 
> > From: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Date: Fri, 30 Aug 2013 12:33:33 +0100
> > Subject: [PATCH] libvhd: use UTC for VHD timestamp
> > 
> > [ported from xapi-project/blktap a79ac2c05f9 ("XOP-289: use UTC for VHD
> > timestamps")]
> > 
> > Currently, the local timezone is factored into VHD timestamps due to the
> > use of mktime(). This breaks "vhd-util check" for VHDs created in one
> > timezone and then moved westward, which results in "primary footer
> > invalid: creation time in future" errors.
> 
> The existing code here is, erm, "surprising".  Thanks for your
> attention to it!
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Applied with the commit message formatted as:

    libvhd: use UTC for VHD timestamp
    
    [ported from xapi-project/blktap a79ac2c05f9 ("XOP-289: use UTC for VHD
    timestamps")]
    
    Currently, the local timezone is factored into VHD timestamps due to the
    use of mktime(). This breaks "vhd-util check" for VHDs created in one
    timezone and then moved westward, which results in "primary footer
    invalid: creation time in future" errors.
    
    Signed-off-by: Andrei Lifchits <andrei.lifchits@xxxxxxxxxx>
    
    Andrei no longer works for Citrix but Germano Percossi (ex-colleague of
    Andrei) contacted Andrei and confirmed that
      1) this work was written on Citrix time,
      2) it is OK to have Andrei's SoB.
    
    Remove unused variable "tm".
    
    Signed-off-by: Germano Percossi <germano.percossi@xxxxxxxxxx>
    Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel