[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1 V2] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed



On 9/4/2013 3:53 AM, Jan Beulich wrote:
On 03.09.13 at 04:36, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
wrote:
On 9/1/2013 3:40 PM, Andrew Cooper wrote:
On 31/08/2013 01:41, suravee.suthikulpanit@xxxxxxx wrote:
@@ -175,6 +176,15 @@ static int __init amd_iommu_setup_dom0_device(u8 devfn, 
struct pci_dev *pdev)
  
      if ( unlikely(!iommu) )
      {
+        /* Filter the bridge devices */
+        if ( (pdev->type == DEV_TYPE_PCI_HOST_BRIDGE) )
+        {
+            AMD_IOMMU_DEBUG("Skipping bridge %04x:%02x:%02x.%u (type 
%x)\n",
+                        pdev->seg, PCI_BUS(bdf), PCI_SLOT(bdf), 
PCI_FUNC(bdf),
+                        pdev->type);
I know this is being picky, but I would prefer "Skipping host bridge"
here, to avoid any possible confusion that non-host bridges might be
considered for being skipped.

~Andrew

I'm fine with that.  Jan, would you mind modifying the message when you 
commit the code, or you want me to send out a new patch?
I'll try to remember that, but considering the reply I just sent to
the patch itself I don't think you're going to get around doing a
v3, in which case you should do the change yourself.

Jan

I'll take care of it in V3.

Suravee
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.