Re: [Xen-devel] [V1 PATCH 1/5] PVH xen tools: Elf and header change.

["Jan Beulich" <JBeulich@xxxxxxxx>]

 >>> On 05.09.13 at 03:32, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> Add XENFEAT_hvm_callback_vector to elf_xen_feature_names
>  so we can ensure the kernel supports all features requird for 
>  PVH mode. Note, hvm callback is required for PVH. 
>  Also, introduce _XEN_DOMINF_pvh_guest.

I suppose you lumped these together just because they're both
outside the tools tree? The domctl change clearly belongs in the
hypervisor series. Whether the libelf change belongs in the tools
or hypervisor series you know. In any event, no matter how
small the constituent parts, these changes continue your model
of randomly mixing changes together rather than structuring
things in a logical way. Once we get to see George's rework of
your hypervisor series, it'll become clear whether allowing the
change here to be left as is would be just one more exception
we make for your stuff to finally make it in, or whether we can
rather get something committed that's well structured.

Jan

> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> ---
>  xen/common/libelf/libelf-dominfo.c |    1 +
>  xen/include/public/domctl.h        |    3 +++
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/xen/common/libelf/libelf-dominfo.c 
> b/xen/common/libelf/libelf-dominfo.c
> index e79b339..25dd892 100644
> --- a/xen/common/libelf/libelf-dominfo.c
> +++ b/xen/common/libelf/libelf-dominfo.c
> @@ -27,6 +27,7 @@ static const char *const elf_xen_feature_names[] = {
>      [XENFEAT_auto_translated_physmap] = "auto_translated_physmap",
>      [XENFEAT_supervisor_mode_kernel] = "supervisor_mode_kernel",
>      [XENFEAT_pae_pgdir_above_4gb] = "pae_pgdir_above_4gb",
> +    [XENFEAT_hvm_callback_vector] = "hvm_callback_vector",
>      [XENFEAT_dom0] = "dom0"
>  };
>  static const unsigned elf_xen_features =
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index 4c5b2bb..6b1aa11 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -89,6 +89,9 @@ struct xen_domctl_getdomaininfo {
>   /* Being debugged.  */
>  #define _XEN_DOMINF_debugged  6
>  #define XEN_DOMINF_debugged   (1U<<_XEN_DOMINF_debugged)
> +/* domain is PVH */
> +#define _XEN_DOMINF_pvh_guest 7
> +#define XEN_DOMINF_pvh_guest   (1U<<_XEN_DOMINF_pvh_guest)
>   /* XEN_DOMINF_shutdown guest-supplied code.  */
>  #define XEN_DOMINF_shutdownmask 255
>  #define XEN_DOMINF_shutdownshift 16
> -- 
> 1.7.2.3




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel