[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [xen-devel] [Patch 0/4] Xen stack trace printing improvements

>>> On 09.09.13 at 14:28, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 09/09/13 12:09, Keir Fraser wrote:
>> On 09/08/2013 20:55, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:
>>> This series consists of improvements to Xen's ability to print traces of its
>>> own stack, and specifically for the stack overflow case to be able to use
>>> frame pointers in a debug build.
>>> I have dev tested the series in debug and non-debug cases, with and without
>>> memory guards, and I believe that all the stack traces look correct.  
> However,
>>> I would greatly appreciate a second opinion on the boundary conditions.
>>> The 4th patch is included for anyone wishing to easily test the series; It 
> is
>>> not intended for committing.
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> CC: Keir Fraser <keir@xxxxxxx>
>>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>> CC: Tim Deegan <tim@xxxxxxx>
>> Acked-by: Keir Fraser <keir@xxxxxxx>
> Thanks for the ack, but I would like to hold off on committing this
> until I have fixed the bug for following frame pointers through
> exception frames.

Ah, that's why you didn't ping for an ack yourself? I had this in my
to-be-committed-eventually list of things, but with your comment
above I assume you'll re-submit once you sorted out that remaining
item, and I can therefore drop it from that list of mine.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.