[Xen-devel] [PATCH v1 00/13] x86/PMU: Xen PMU PV support

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

The following patch series adds PMU support in Xen for PV guests. There is a
companion patchset for Linux kernel. In addition, another set of changes will
be provided (later) for userland perf code.

This version has following limitations:
* For accurate profiling of dom0/Xen dom0 VCPUs should be pinned.
* Hypervisor code is only profiled on processors that have running dom0 VCPUs
on them.
* No backtrace support.
* Will fail to load under XSM: we ran out of bits in permissions vector and
this needs to be fixed separately


A few notes that may help reviewing:

* A shared data structure (xenpmu_data_t) between each PV VPCU and hypervisor
CPU is used for passing registers' values as well as PMU state at the time of
PMU interrupt.

* PMU interrupts are taken by hypervisor at NMI level for both HVM and PV.

* Guest's interrupt handler does not read/write PMU MSRs directly. Instead, it
accesses xenpmu_data_t and flushes it to HW it before returning.

* PMU mode is controlled at runtime via 
/sys/hypervisor/pmu/pmu/{pmu_mode,pmu_flags}
in addition to 'vpmu' boot option (which is preserved for back compatibility).
The following modes are provided:
  * disable: VPMU is off
  * enable: VPMU is on. Guests can profile themselves, dom0 profiles itself and 
Xen
  * priv_enable: dom0 only profiling. dom0 collects samples for everyone. 
Sampling
    in guests is suspended.

* /proc/xen/xensyms file exports hypervisor's symbols to dom0 (similar to
  /proc/kallsyms)

* VPMU infrastructure is now used for both HVM and PV and therefore has been 
moved
up from hvm subtree


Boris Ostrovsky (13):
  Export hypervisor symbols
  Set VCPU's is_running flag closer to when the VCPU is dispatched
  x86/PMU: Stop AMD counters when called from vpmu_save_force()
  x86/VPMU: Minor VPMU cleanup
  intel/VPMU: Clean up Intel VPMU code
  x86/PMU: Add public xenpmu.h
  x86/PMU: Make vpmu not HVM-specific
  x86/PMU: Interface for setting PMU mode and flags
  x86/PMU: Initialize PMU for PV guests
  x86/PMU: Add support for PMU registes handling on PV guests
  x86/PMU: Handle PMU interrupts for PV guests
  x86/PMU: Save VPMU state for PV guests during context switch
  x86/PMU: Move vpmu files up from hvm directory

 xen/arch/x86/Makefile                          |   9 +-
 xen/arch/x86/apic.c                            |  13 -
 xen/arch/x86/domain.c                          |  18 +-
 xen/arch/x86/hvm/Makefile                      |   1 -
 xen/arch/x86/hvm/svm/Makefile                  |   1 -
 xen/arch/x86/hvm/svm/entry.S                   |   2 +
 xen/arch/x86/hvm/svm/vpmu.c                    | 494 -------------
 xen/arch/x86/hvm/vmx/Makefile                  |   1 -
 xen/arch/x86/hvm/vmx/entry.S                   |   1 +
 xen/arch/x86/hvm/vmx/vmcs.c                    |  59 ++
 xen/arch/x86/hvm/vmx/vpmu_core2.c              | 894 -----------------------
 xen/arch/x86/hvm/vpmu.c                        | 266 -------
 xen/arch/x86/oprofile/op_model_ppro.c          |   3 +-
 xen/arch/x86/platform_hypercall.c              |  14 +
 xen/arch/x86/traps.c                           |  38 +-
 xen/arch/x86/vpmu.c                            | 545 ++++++++++++++
 xen/arch/x86/vpmu_amd.c                        | 486 +++++++++++++
 xen/arch/x86/vpmu_intel.c                      | 938 +++++++++++++++++++++++++
 xen/arch/x86/x86_64/asm-offsets.c              |   1 +
 xen/arch/x86/x86_64/compat/entry.S             |   4 +
 xen/arch/x86/x86_64/entry.S                    |   4 +
 xen/arch/x86/x86_64/platform_hypercall.c       |   2 +-
 xen/common/event_channel.c                     |   1 +
 xen/common/schedule.c                          |  10 +-
 xen/common/symbols-dummy.c                     |   1 +
 xen/common/symbols.c                           |  78 +-
 xen/include/asm-x86/domain.h                   |   3 +
 xen/include/asm-x86/hvm/vcpu.h                 |   3 -
 xen/include/asm-x86/hvm/vmx/vmcs.h             |   3 +-
 xen/include/asm-x86/hvm/vmx/vpmu_core2.h       |  51 --
 xen/include/asm-x86/hvm/vpmu.h                 | 104 ---
 xen/include/asm-x86/irq.h                      |   1 -
 xen/include/asm-x86/mach-default/irq_vectors.h |   1 -
 xen/include/asm-x86/vpmu.h                     |  97 +++
 xen/include/public/platform.h                  |  21 +
 xen/include/public/xen.h                       |   2 +
 xen/include/public/xenpmu.h                    | 138 ++++
 xen/include/xen/hypercall.h                    |   4 +
 xen/include/xen/softirq.h                      |   1 +
 xen/include/xen/symbols.h                      |   4 +
 xen/tools/symbols.c                            |   4 +
 41 files changed, 2465 insertions(+), 1856 deletions(-)
 delete mode 100644 xen/arch/x86/hvm/svm/vpmu.c
 delete mode 100644 xen/arch/x86/hvm/vmx/vpmu_core2.c
 delete mode 100644 xen/arch/x86/hvm/vpmu.c
 create mode 100644 xen/arch/x86/vpmu.c
 create mode 100644 xen/arch/x86/vpmu_amd.c
 create mode 100644 xen/arch/x86/vpmu_intel.c
 delete mode 100644 xen/include/asm-x86/hvm/vmx/vpmu_core2.h
 delete mode 100644 xen/include/asm-x86/hvm/vpmu.h
 create mode 100644 xen/include/asm-x86/vpmu.h
 create mode 100644 xen/include/public/xenpmu.h

-- 
1.8.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel