Re: [Xen-devel] [PATCH v2 5/5] xl: test script for the cpumap parser (for vCPU pinning)

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("[PATCH v2 5/5] xl: test script for the cpumap parser 
(for vCPU pinning)"):
> This commit introduces "check-xl-vcpupin-parse" for helping
> verifying and debugging the (v)CPU bitmap parsing code in xl.
> 
> The script runs "xl -N vcpu-pin 0 all <some strings>"
> repeatedly, with various input strings, and checks that the
> output is as expected.

This is a nice idea.  But can we please have this use the same random
seed each time, and/or report the seed ?  Otherwise you can get a very
annoying situation where a test fails but you can't repro it...

I think it would be better, TBH, if you separated out the test
generation from the execution.  check-xl-vif-parse et al have the test
data as an annex to the harness material, but you could have it in a
separate file which you could have a script to generate.

Also the use of "sleep 1" needs to go.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel