[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided

  • To: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Wed, 11 Sep 2013 13:13:09 +0200
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • Delivery-date: Wed, 11 Sep 2013 11:14:27 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Message-ID:Date:From:Organization:User-Agent: MIME-Version:To:CC:Subject:References:In-Reply-To: Content-Type:Content-Transfer-Encoding; b=Ny/OY+t16nhfWRpfNzGvriV+TqfLxipbp6EwuWZYP1rsWVljdSCcjbhU V7YiMOTm2NvKu0plE/fsJOT+dRrExSQ3RbTVrarmQaXMfntl6La/eMPAx xpclA7UghZJ0HS5NYvKZYzUAsFOkM9l1aVQtPyuBOv4l9bfzAxAK4x3PS f6Dzm7SmptzS7fUa0NR+j8MA76OuHUQurUV0lcfCxa+Uu62e4x7/Oby6O 5xuT405CA7xqgdpBcTogOFYFmOfEN;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 11.09.2013 13:06, Dario Faggioli wrote:
since it errors out, asking for at least one argument, and does
not display any useful output, which is wrong (we want the list
and the info about all the existing cpupools).

IOW, the output is as follows:

  ~# xl cpupool-list -c
  'xl cpupool-list' requires at least 1 argument.

While it should be as follows:

  ~# xl cpupool-list -c
  Name               CPU list
  Pool-0             0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15

Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Acked-by: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>

  tools/libxl/xl_cmdimpl.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 884f050..35b3e29 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -6570,7 +6570,7 @@ int main_cpupoollist(int argc, char **argv)
      char *name;
      int ret = 0;

-    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 1) {
+    SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 0) {
      case 'c':
          opt_cpus = 1;

Xen-devel mailing list

Juergen Gross                 Principal Developer Operating Systems
PBG PDG ES&S SWE OS6                   Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.