Re: [Xen-devel] [PATCH RFC v12 12/21] pvh: Support guest_kernel_mode for PVH

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.09.13 at 18:25, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> This will be requred in order to do emulated_privops for PVH.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

albeit for generality's sake ...

> +#define guest_kernel_mode(v, r)                                   \
> +    (is_pvh_vcpu(v) ? hvm_kernel_mode(v) :                        \

... this could probably become !is_pv_vcpu() (or
has_hvm_container_vcpu(), if that doesn't go away).

> +     (!is_pv_32bit_vcpu(v) ?                                      \
> +      (ring_3(r) && ((v)->arch.flags & TF_kernel_mode)) :         \
> +      (ring_1(r))))

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel