Re: [Xen-devel] [PATCH] qemu-traditional: do not strip binaries during make install

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Sep 19, Matthew Daley wrote:

> On Thu, Sep 19, 2013 at 6:11 AM, Olaf Hering <olaf@xxxxxxxxx> wrote:
> > @@ -243,7 +243,7 @@ endif
> >  install: all $(if $(BUILD_DOCS),install-doc)
> >         mkdir -p "$(DESTDIR)$(bindir)"
> >  ifneq ($(TOOLS),)
> > -       $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > +       $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> >  endif
> >  ifneq ($(BLOBS),)
> >         mkdir -p "$(DESTDIR)$(datadir)"
> > diff --git a/Makefile.target b/Makefile.target
> > index 19bb0fd..1cf7f34 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -755,7 +755,7 @@ clean:
> >
> >  install: all install-hook
> >  ifneq ($(PROGS),)
> > -       $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> > +       $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> 
> Perhaps it would be worthwhile to only do this if debug=y is set, like
> in commit 8e4610e (which is the equivalent of this patch for
> qemu-xen)?

I dont think any "make install" has to modify the binaries. If debuginfo
was requested by passing "-g" via CFLAGS then the generated debuginfo
has to be preserved during make install.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel