Re: [Xen-devel] [PATCH 0/6] x86: emulation improvements

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.09.13 at 18:12, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 19/09/2013 16:40, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> 1: x86/HVM: properly handle MMIO reads and writes wider than a machine word
>> 2: x86: fix dependencies of emulator test
>> 3: x86_emulate: MOVSXD must read source operand just once
>> 4: x86_emulate: PUSH <mem> must read source operand just once
>> 5: x86_emulate: fix flag setting for 8-bit signed multiplication
>> 6: x86_emulate: fold wide reads
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Nice.
> 
> Acked-by: Keir Fraser <keir@xxxxxxx>

I'm going to commit them with two tiny adjustments:

In the first patch I simplified the initializer of "chunk" to

        chunk = min(bytes, 1U << LONG_BYTEORDER)

And in the fourth patch I replaced the newly added conditional in
the 8-bit case with an ASSERT() (which in turn requires the test
utility to be adjusted to have ASSERT() available).

I'm sure you're fine with both.

There's going to be one more, fixing wrap around handling for
repeated string instructions; need to still give this some minimal
testing before submitting.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel