Re: [Xen-devel] [PATCH 2/8] xen/arm: replace io{read, write}{l, b} with {read, write}{l, b}

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2013-09-13 at 17:33 +0100, Julien Grall wrote:
> > read/write are used in common driver code (specifically ns16550) so instead 
> > of
> > keeping our own variant around lets replace it with the more standard ones.
> > 
> > At the same time resync with Linux making the "based on" comment in both 
> > setsof
> s/setsof/sets of/
> 
> Can you precise the linux commit for the future?

It's v3.11, I've mentioned that in the updated version.
 
> > -static inline void iowritel(const volatile void __iomem *addr, uint32_t 
> > val)
> > +static inline void __raw_writeq(u64 val, volatile void __iomem *addr)
> >  {
> > -    dsb();
> > -    asm volatile("str %w0, [%1]" : : "r" (val), "r" (addr));
> > +        asm volatile("str %0, [%1]" : : "r" (val), "r" (addr));
> 
> The indentation seems wrong here and some other places.

I deliberately retained the Linux style of indentation for these
functions which came direct from Linux. Makes a visual check that they
are the same much easier.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel