Re: [Xen-devel] [PATCH 6/7] xen/arm: Basic support for sunxi/sun7i platform.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2013-09-20 at 19:55 +0100, Julien Grall wrote:
> On 09/20/2013 05:18 PM, Ian Campbell wrote:
> > Specifically cubieboard2
> >
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> >   xen/arch/arm/platforms/Makefile |    1 +
> >   xen/arch/arm/platforms/sunxi.c  |   42 
> > +++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 43 insertions(+)
> >   create mode 100644 xen/arch/arm/platforms/sunxi.c
> >
> > diff --git a/xen/arch/arm/platforms/Makefile 
> > b/xen/arch/arm/platforms/Makefile
> > index 4aa82e8..8c77ace 100644
> > --- a/xen/arch/arm/platforms/Makefile
> > +++ b/xen/arch/arm/platforms/Makefile
> > @@ -2,3 +2,4 @@ obj-y += vexpress.o
> >   obj-y += exynos5.o
> >   obj-y += midway.o
> >   obj-y += omap5.o
> > +obj-y += sunxi.o
> > diff --git a/xen/arch/arm/platforms/sunxi.c b/xen/arch/arm/platforms/sunxi.c
> > new file mode 100644
> > index 0000000..ee0f39b
> > --- /dev/null
> > +++ b/xen/arch/arm/platforms/sunxi.c
> > @@ -0,0 +1,42 @@
> > +/*
> > + * xen/arch/arm/platforms/sunxi.c
> > + *
> > + * SUNXI (AllWinner A20/A31) specific settings
> > + *
> > + * Copyright (c) 2013 Citrix Systems.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <asm/p2m.h>
> > +#include <xen/config.h>
> > +#include <asm/platform.h>
> > +#include <xen/mm.h>
> > +#include <xen/device_tree.h>
> 
> Do we need all these includes? asm/platform.h should be enough.

Probably not, many of them are a hangover from the previous hacky
version or copied from whichever file I started from ;-)

> 
> > +
> > +static const char const *sunxi_dt_compat[] __initdata =
> 
> It should be __initconst.


Ack.

> > +{
> > +    "allwinner,sun7i-a20",
> > +    NULL
> > +};
> > +
> > +PLATFORM_START(sunxi, "Allwinner A20")
> > +    .compatible = sunxi_dt_compat,
> > +PLATFORM_END
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> >
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel