[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v12 16/21] pvh: Use PV handlers for emulated forced invalid ops, cpuid, and IO

>>> On 23.09.13 at 15:48, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> On 18/09/13 16:31, Jan Beulich wrote:
>>> +void propagate_page_fault(unsigned long addr, u16 error_code)
>>> +{
>>> +    is_pvh_vcpu(current)
>>> +        ? hvm_inject_page_fault(error_code, addr)
>>> +        : pv_inject_page_fault(addr, error_code);
>> Even if not written down in CODINGSTYLE, the majority of other
>> cases in the code has the operators last thing on a line rather than
>> first.
> In the case of boolean operators (&&, ||) I think it makes a lot more 
> sense to put them at the beginning of the line; I think it makes the 
> code easier to read.

As a matter of fact my personal preference is to have all
operators at the start of a line (thus making it immediately
obvious that the expression is being continued), but in Xen
I try to respect the different model (albeit occasionally I


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.