[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] libxc: add LZ4 decompression support

>>> On 23.09.13 at 17:00, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Mon, 2013-09-23 at 15:56 +0100, Jan Beulich wrote:
>> Since there's no shared or static library to link against, this simply
>> re-uses the hypervisor side code. However, I only audited the code
>> added here for possible security issues, not the referenced code in
>> the hypervisor tree.
> With that in mind, you aren't adding a
> tools/libxc/xc_dom_decompress_unsafe_lz4.c which would enable this stuff
> in pvgrub domains.

I'd prefer to leave this to someone who knows what he's doing;
I don't think I even know when the respective build portion gets
enabled. Does this hang off the stubdom build (which I try to
avoid because of the big number of build warnings it produces,
all giving the impression that I'm not doing this right)? Despite it
being guarded by __MINIOS__ checks, I don't think the mini-os
build alone triggers this.

And then again I specifically placed the newly added code outside
the __MINIOS__ guarded region, as from looking at the code I
concluded that these "unsafe" decompressors do nothing else
than what I did here: Include the hypervisor sources. So I was
sort of hoping that the extra stuff wouldn't even be necessary


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.