Re: [Xen-devel] [PATCH v2 7/9] xen: arm: use symbolic names for MPIDR bits.

[Tim Deegan <tim@xxxxxxx>]

At 11:49 +0100 on 26 Sep (1380196154), Ian Campbell wrote:
> arm32 already uses MPIDR_HWID_MASK, use it on arm64 too. Add MPIDR_{SMP,UP}
> (and bitwise equivalents) and use them.
>  /* MPIDR Multiprocessor Affinity Register */
> -#define MPIDR_UP            (1 << 30)
> -#define MPIDR_SMP           (1 << 31)
> +#define _MPIDR_UP           (30)
> +#define MPIDR_UP            (1 << _MPIDR_UP)
> +#define _MPIDR_SMP          (31)
> +#define MPIDR_SMP           (1 << _MPIDR_SMP)

Not that you're introducing this, but this should be 1u or 1ul; 
1<<31 is undefined.  :(

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel